search

codingdavinci / relaunch2018

This is the new Coding da Vinci website (online since September 2020).
https://codingdavinci.de
GNU General Public License v2.0
1 stars 1 forks source link

Einfache Seiten: Box/Box-Gruppen background colours #174

Closed lucyWMDE closed 4 years ago

lucyWMDE commented 4 years ago

Stephanie's suggestion outlined in figma is to restrict the use of box background colours to white (maybe also the pink of the menu?) plus on event pages one/both regional colours. Stephanie: is that right? @Snater: Is it possible to restrict colours like that on specific pages?

stffb commented 4 years ago

Right

Snater commented 4 years ago

The colors are already restricted through the corresponding taxonomy. I don't think it's impossible, but adding the regional colours could be a little bit tricky.

lucyWMDE commented 4 years ago

ok - don't spend a lot of time on it. If it's too tricky to restrict to regional colours we'll just go with page background (F5F5F5) and the menu colour (FCD9C8).

Snater commented 4 years ago

OK, the colours should be limited with the next update. This is just a change in the Hintergrundfarben taxonomy, so no commit here.

Just dropping in some explanation here: Using the regional colours would be tricky as it would kind of break the data model boundaries. We would need to inject the information from a parent component. At the moment, the information is not defined in a parent component, but in the same component (the Event instance). So, defining the colour scheme on the Event instance together with specifying box paragraph background colours does not work properly.

If we had, for example, something like a Region content type which we would create an instance of for every region and each Event content type instance would reference a Region instance, we could bind a regional colour scheme to a region an inject that into the Event instance. That would be a clean solution, but I am sceptical it's worth blowing up the data model just for the purpose of being able to select specific regional colours in the box paragrahs.

lucyWMDE commented 4 years ago

agree. Thanks for the explanation :) (Realised one of the colours I'd given you for the background colours was wrong (hellgrau should have been white #FFF - I've changed it in the taxonomy.)