search

codingdavinci / relaunch2018

This is the new Coding da Vinci website (online since September 2020).
https://codingdavinci.de
GNU General Public License v2.0
1 stars 1 forks source link

News article/Abschnitt Bild - layout #259

Closed lucyWMDE closed 3 years ago

lucyWMDE commented 4 years ago

I think "Abschitte Bild" as used for news articles might not have been fully styled? I'd have assumed it'd come out the same as Abschnitt Bild as used on the Event pages. eg https://test.codingdavinci.de/de/news/coding-da-vinci-stipendien-gehen-die-zweite-runde The image should be centered on the page in line with text in, for example, Abschnitt text. I think that's the only issue though. Caption and spacing looks fine and the image resolution problem as described in #258 is actually totally fine here.

Snater commented 4 years ago

The left and right container margins were just overwritten.

lucyWMDE commented 4 years ago

still not fixed :/ Abschnitt Bild still justifies to the left - should be centred. Perhaps something went wrong in implementation..?

Snater commented 4 years ago

Sorry, I accidentally pushed the changes for this issue and #242 to your branch (https://github.com/codingdavinci/relaunch2018/compare/lucyWMDE-patch-1). I will merge that branch into master on Monday, unless you are quicker than me.

Snater commented 4 years ago

Merged branch. Please check again after the current master being deployed.

lucyWMDE commented 3 years ago

@mbuechner These changes (see comment above) are not yet evident on the site. Has everything been deployed?