search

codingforeveryone / codingforeveryone.github.io

Website repo
7 stars 1 forks source link

Check whether the package.json within /site is necessary #22

Closed pjcevans closed 8 years ago

pjcevans commented 8 years ago

As it's causing an issue at jekyll / bundle install - Also in in current PR I have renamed it to prevent this from happening this time + in the future

Out of interest this was the log file generated

jwhchambers commented 8 years ago

@pjcevans It isn't needed. I have removed it now!

pjcevans commented 8 years ago

Great, thanks for clearing that up - I'll remove the .bak version from the latest branch then

samhstn commented 8 years ago

@pjcevans @jwhchambers Just so you know the reason that it wasn't working was because there was a trailing comma on line 24 check the line here. If you just removed the comma it would have worked

Generally a node project should have a package.json file in the root, it is the first thing a node developer will look at when they look at a node project. But since we are just using the site directory for reference it doesn't really matter