codingjoe / django-pictures

Responsive cross-browser image library using modern codes like AVIF & WebP
BSD 2-Clause "Simplified" License
248 stars 20 forks source link

Fix caching issue on empty dimention fields #172

Closed codingjoe closed 5 months ago

codingjoe commented 5 months ago

The width and height fields may be empty, like in cases where you newly add the fields. In those cases, they width and hight properties shall not return the false null values but read the dimentions form file.

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (640a4f8) to head (4532f44).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #172 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 13 13 Lines 464 466 +2 ========================================= + Hits 464 466 +2 ``` | [Flag](https://app.codecov.io/gh/codingjoe/django-pictures/pull/172/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Johannes+Maron) | Coverage Δ | | |---|---|---| | [celery](https://app.codecov.io/gh/codingjoe/django-pictures/pull/172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Johannes+Maron) | `83.47% <100.00%> (+0.07%)` | :arrow_up: | | [cleanup](https://app.codecov.io/gh/codingjoe/django-pictures/pull/172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Johannes+Maron) | `84.12% <100.00%> (+0.06%)` | :arrow_up: | | [dj4.1](https://app.codecov.io/gh/codingjoe/django-pictures/pull/172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Johannes+Maron) | `84.12% <100.00%> (+0.06%)` | :arrow_up: | | [dj4.2](https://app.codecov.io/gh/codingjoe/django-pictures/pull/172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Johannes+Maron) | `84.12% <100.00%> (+0.06%)` | :arrow_up: | | [django-rq](https://app.codecov.io/gh/codingjoe/django-pictures/pull/172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Johannes+Maron) | `83.47% <100.00%> (+0.07%)` | :arrow_up: | | [dramatiq](https://app.codecov.io/gh/codingjoe/django-pictures/pull/172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Johannes+Maron) | `83.47% <100.00%> (+0.07%)` | :arrow_up: | | [drf](https://app.codecov.io/gh/codingjoe/django-pictures/pull/172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Johannes+Maron) | `92.91% <100.00%> (+0.03%)` | :arrow_up: | | [macos-latest](https://app.codecov.io/gh/codingjoe/django-pictures/pull/172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Johannes+Maron) | `84.33% <100.00%> (+0.06%)` | :arrow_up: | | [py3.10](https://app.codecov.io/gh/codingjoe/django-pictures/pull/172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Johannes+Maron) | `84.12% <100.00%> (+0.06%)` | :arrow_up: | | [py3.12](https://app.codecov.io/gh/codingjoe/django-pictures/pull/172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Johannes+Maron) | `84.12% <100.00%> (+0.06%)` | :arrow_up: | | [py3.8](https://app.codecov.io/gh/codingjoe/django-pictures/pull/172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Johannes+Maron) | `84.12% <100.00%> (+0.06%)` | :arrow_up: | | [py3.9](https://app.codecov.io/gh/codingjoe/django-pictures/pull/172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Johannes+Maron) | `84.12% <100.00%> (+0.06%)` | :arrow_up: | | [ubuntu-latest](https://app.codecov.io/gh/codingjoe/django-pictures/pull/172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Johannes+Maron) | `84.12% <100.00%> (+0.06%)` | :arrow_up: | | [windows-latest](https://app.codecov.io/gh/codingjoe/django-pictures/pull/172/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Johannes+Maron) | `75.80% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Johannes+Maron#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.