search

codingjoe / django-pictures

Responsive cross-browser image library using modern codes like AVIF & WebP
BSD 2-Clause "Simplified" License
248 stars 20 forks source link

Fix #176 -- Allow overriding the img-tag dimensions attributes #177

Closed atnartur closed 3 months ago

atnartur commented 3 months ago

Closes #176

codingjoe commented 3 months ago

Please let me know if you need help with the tests. I believe it's only the attribute order that changed, should be pretty straightforward. However, I would appreciate it if you could add a new test to prevent regression.

atnartur commented 3 months ago

Thank you very much for your support and advice! I added a test to check new attributes and also fixed alt="None" value supported with the corresponding test.

I hope, everything will be okay in CI this time.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (96af07e) to head (2afe108).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #177 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 13 13 Lines 486 486 ========================================= Hits 486 486 ``` | [Flag](https://app.codecov.io/gh/codingjoe/django-pictures/pull/177/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Johannes+Maron) | Coverage Δ | | |---|---|---| | [celery](https://app.codecov.io/gh/codingjoe/django-pictures/pull/177/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Johannes+Maron) | `84.77% <100.00%> (ø)` | | | [cleanup](https://app.codecov.io/gh/codingjoe/django-pictures/pull/177/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Johannes+Maron) | `88.27% <100.00%> (ø)` | | | [dj4.1](https://app.codecov.io/gh/codingjoe/django-pictures/pull/177/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Johannes+Maron) | `88.27% <100.00%> (ø)` | | | [dj4.2](https://app.codecov.io/gh/codingjoe/django-pictures/pull/177/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Johannes+Maron) | `88.27% <100.00%> (ø)` | | | [django-rq](https://app.codecov.io/gh/codingjoe/django-pictures/pull/177/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Johannes+Maron) | `84.77% <100.00%> (ø)` | | | [dramatiq](https://app.codecov.io/gh/codingjoe/django-pictures/pull/177/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Johannes+Maron) | `84.77% <100.00%> (ø)` | | | [drf](https://app.codecov.io/gh/codingjoe/django-pictures/pull/177/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Johannes+Maron) | `96.29% <100.00%> (ø)` | | | [macos-latest](https://app.codecov.io/gh/codingjoe/django-pictures/pull/177/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Johannes+Maron) | `88.47% <100.00%> (ø)` | | | [py3.10](https://app.codecov.io/gh/codingjoe/django-pictures/pull/177/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Johannes+Maron) | `88.27% <100.00%> (ø)` | | | [py3.12](https://app.codecov.io/gh/codingjoe/django-pictures/pull/177/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Johannes+Maron) | `88.27% <100.00%> (ø)` | | | [py3.8](https://app.codecov.io/gh/codingjoe/django-pictures/pull/177/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Johannes+Maron) | `88.27% <100.00%> (ø)` | | | [py3.9](https://app.codecov.io/gh/codingjoe/django-pictures/pull/177/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Johannes+Maron) | `88.27% <100.00%> (ø)` | | | [ubuntu-latest](https://app.codecov.io/gh/codingjoe/django-pictures/pull/177/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Johannes+Maron) | `88.27% <100.00%> (ø)` | | | [windows-latest](https://app.codecov.io/gh/codingjoe/django-pictures/pull/177/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Johannes+Maron) | `81.52% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Johannes+Maron#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.