codingjoe / django-pictures

Responsive cross-browser image library using modern codes like AVIF & WebP
BSD 2-Clause "Simplified" License
248 stars 20 forks source link

Improve E101 help text #61

Closed codingjoe closed 1 year ago

codingjoe commented 1 year ago

@1r00t I hope this help text is better. Maybe you could give it a quick read and leave me a suggestion how it could be further improved. I'd appreciate that a lot. Thx Joe!

codecov[bot] commented 1 year ago

Codecov Report

Base: 100.00% // Head: 99.27% // Decreases project coverage by -0.72% :warning:

Coverage data is based on head (41cff4d) compared to base (acb0a0d). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #61 +/- ## =========================================== - Coverage 100.00% 99.27% -0.73% =========================================== Files 9 9 Lines 276 276 =========================================== - Hits 276 274 -2 - Misses 0 2 +2 ``` | [Impacted Files](https://codecov.io/gh/codingjoe/django-pictures/pull/61?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Johannes+Maron) | Coverage Δ | | |---|---|---| | [pictures/utils.py](https://codecov.io/gh/codingjoe/django-pictures/pull/61/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Johannes+Maron#diff-cGljdHVyZXMvdXRpbHMucHk=) | `96.96% <0.00%> (-3.04%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Johannes+Maron). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Johannes+Maron)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

1r00t commented 1 year ago

Hey. Thanks for the fast reply. I understand it now and it works great! I needed to make these fields allow blank and null for it to work from the admin panel. Now they automatically populate!

codingjoe commented 1 year ago

@1r00t ideally, you would make those fields editable=False. That way they don't pop up in the admin. You'll probably also need to populate empty fields for existing images for optimal performance.