codingjoe / django-pictures

Responsive cross-browser image library using modern codes like AVIF & WebP
BSD 2-Clause "Simplified" License
248 stars 20 forks source link

Fix #89 -- Handle invalid container values in DRF #99

Closed codingjoe closed 1 year ago

codingjoe commented 1 year ago

A user may pass any container value to the endpoint, and we need to ensure proper error handling and error messages.

Co-authored-by: truongvan truongvan@users.noreply.github.com

codecov[bot] commented 1 year ago

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage :thumbsup:

Coverage data is based on head (0ab6d17) compared to base (c947a5e). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #99 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 13 13 Lines 436 443 +7 ========================================= + Hits 436 443 +7 ``` | Flag | Coverage Δ | | |---|---|---| | celery | `85.55% <0.00%> (-1.38%)` | :arrow_down: | | cleanup | `86.23% <0.00%> (-1.39%)` | :arrow_down: | | dj4.0 | `86.23% <0.00%> (-1.39%)` | :arrow_down: | | dj4.1 | `86.23% <0.00%> (-1.39%)` | :arrow_down: | | dramatiq | `85.55% <0.00%> (-1.38%)` | :arrow_down: | | drf | `93.90% <100.00%> (+0.09%)` | :arrow_up: | | macos-latest | `86.45% <0.00%> (-1.39%)` | :arrow_down: | | py3.10 | `86.23% <0.00%> (-1.39%)` | :arrow_down: | | py3.11 | `86.23% <0.00%> (-1.39%)` | :arrow_down: | | py3.8 | `86.23% <0.00%> (-1.39%)` | :arrow_down: | | py3.9 | `86.23% <0.00%> (-1.39%)` | :arrow_down: | | ubuntu-latest | `86.23% <0.00%> (-1.39%)` | :arrow_down: | | windows-latest | `78.76% <0.00%> (-1.94%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Johannes+Maron#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/codingjoe/django-pictures/pull/99?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Johannes+Maron) | Coverage Δ | | |---|---|---| | [pictures/contrib/rest\_framework.py](https://codecov.io/gh/codingjoe/django-pictures/pull/99?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Johannes+Maron#diff-cGljdHVyZXMvY29udHJpYi9yZXN0X2ZyYW1ld29yay5weQ==) | `100.00% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Johannes+Maron). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Johannes+Maron)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.