codingjoe / relint

Write your own linting rules using regular expressions.
MIT License
51 stars 10 forks source link

Add `--ignore-warnings` argument #46

Closed amureki closed 1 year ago

amureki commented 1 year ago

In my usecase, I want to show warnings to the developer (via pre-commit), but don't want to output them in CI. Here such setting would be handy.

P.S. I am basing this PR on top of #45 as it has fixed tests suite, which is needed here.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change

Comparison is base (8a4491e) 100.00% compared to head (653d16c) 100.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #46 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 5 5 Lines 127 130 +3 ========================================= + Hits 127 130 +3 ``` | [Impacted Files](https://codecov.io/gh/codingjoe/relint/pull/46?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Johannes+Maron) | Coverage Δ | | |---|---|---| | [relint/\_\_main\_\_.py](https://codecov.io/gh/codingjoe/relint/pull/46?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Johannes+Maron#diff-cmVsaW50L19fbWFpbl9fLnB5) | `100.00% <100.00%> (ø)` | | | [relint/config.py](https://codecov.io/gh/codingjoe/relint/pull/46?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Johannes+Maron#diff-cmVsaW50L2NvbmZpZy5weQ==) | `100.00% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Johannes+Maron). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Johannes+Maron)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

amureki commented 1 year ago

@codingjoe I addressed text comment. Regarding rich and click - wonderful idea, I like these packages and agree that they are well-maintained and can improve DX here.

But this (especially click) could be a bigger change, so we'd better go with it separately. What do you think?