search

codingjoe / relint

Write your own linting rules using regular expressions.
MIT License
51 stars 10 forks source link

Use CI linters in pre-commit #47

Closed amureki closed 1 year ago

amureki commented 1 year ago

I noticed that we have pre-commit installed, also a bunch of linters running in CI. However, I had no pre-commit running locally (wrong pre-commit config file), also there were no checks defined.

codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (8a4491e) 100.00% compared to head (cfd99b1) 100.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #47 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 5 5 Lines 127 127 ========================================= Hits 127 127 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Johannes+Maron). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Johannes+Maron)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

amureki commented 1 year ago

@codingjoe I got your point, makes sense. I wonder if we could try https://pre-commit.ci/ (free for open-source repos), which will automatically fix all linting issues.