codingmatty / cerebro-plugin-clipboard

Cerebro plugin to record and fetch list of items on clipboard
13 stars 1 forks source link

Implement permanent storage of clipboard #3

Open KELiON opened 7 years ago

KELiON commented 7 years ago

Now user looses clipboard history after Cerebro restart. Would be cool to store clipboard history for a while. As a default configuration could be 24 hours for text inputs and 1 hour for images.

codingmatty commented 7 years ago

I did have a small concern about this. Because I can't determine what app the text may have come from, when a user copies a password (from an app like 1password), it will end up getting stored, which could be a major security risk.

I really wish I knew how Alfred did it, because they get a lot more context into items on the systems clipboard (i.e. they don't show anything copied from 1password, and they show what app the text was copied from).

Also (just a note), Alfred resets their clipboard after a restart.

codingmatty commented 7 years ago

As for the 1password problem (or more generally, private info on the clipboard), I may have found a solution for the mac, but it involves a custom solution so windows and linux are going to be a lot tougher.

KELiON commented 7 years ago

Also (just a note), Alfred resets their clipboard after a restart. I think I didn't notice it because Alfred used to be launched on my computer all the time, but with Cerebro I'm always switching between prod/dev environments and different versions )

I may have found a solution for the mac Can you share it? I'll also try to dig more

codingmatty commented 7 years ago

I found this code snippet about accessing data on the clipboard with native libraries: https://github.com/electron/electron/issues/2244#issuecomment-151768768

And after playing around with it, realized that all I really care about is the pasteboard types to help filter out certain types, based the spec I found here: http://nspasteboard.org/

rapcal commented 7 years ago

I've recently started using a Linux machine and, coming from Alfred (Mac), I found the work you guys have been doing to be a tremendous help - feeling at home!

This discussion started here where Alfred's awesome snippet feature was also mentioned. Will this topic be treated here as well or should I open another issue so that this matter is not forgotten?

Thanks a lot for the great work :+1:

codingmatty commented 7 years ago

Go ahead and open a new issue.

I will work on making the clipboard persistent first, and then come back and make them saveable.

On Wed, Mar 15, 2017 at 6:11 PM Raphael Caldas notifications@github.com wrote:

I've recently started using a Linux machine and, coming from Alfred (Mac), I found the work you guys have been doing to be a tremendous help - feeling at home!

This discussion started here https://github.com/KELiON/cerebro/issues/166 where Alfred's awesome snippet feature was also mentioned https://github.com/KELiON/cerebro/issues/166#issuecomment-282614021. Will this topic be treated here as well or should I open another issue so that this matter is not forgotten?

Thanks a lot for the great work 👍

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/codingmatty/cerebro-plugin-clipboard/issues/3#issuecomment-286908428, or mute the thread https://github.com/notifications/unsubscribe-auth/AF1fkHyFVTwcFjcqS2xRK4RAIqv03pmDks5rmHAVgaJpZM4MTC_j .

rapcal commented 7 years ago

Thanks a lot, @codingmatty. Done.

Unfortunately my javascript skills don't allow me to contribute here. If you have some kind of bounty program, though, I'd be really glad to pitch in.