search

codingo / Reconnoitre

A security tool for multithreaded information gathering and service enumeration whilst building directory structures to store results, along with writing out recommendations for further testing.
GNU General Public License v3.0
2.1k stars 457 forks source link

Refactoring for classes #4

Open codingo opened 7 years ago

codingo commented 7 years ago

The code for Reconnoitre is currently structured into independent methods/files but lacks classes for each file. Recommendation is to create classes for each base file within the project (for example file_helpers.py would contain the class file_helper).

codingo commented 6 years ago

Tagging this as help wanted as this project is a bit lower on my list, if somebody wants to take a crack at this I would very happily merge it over!

evyatarmeged commented 6 years ago

Hey, I have considered taking this on myself. Any special guidelines that should be followed? Hope to squeeze this into my schedule 👍

codingo commented 6 years ago

@evyatarmeged a large component of this will be combining the code that's used to launching processing into a single function/class and properly using that object over the code base. Currently each library (file) within this project reuses the same functions, causing quite a bit of overlap. Outside of that, I believe anything would be a step in the right direction and if you put something together I'm happy to refactor / work on that branch prior to merging if I believe that further changes are needed.

evyatarmeged commented 6 years ago

@codingo I found some spare time and got around to doing some work. I've pushed it in my fork of Reconnoitre under branch "class-refactoring-001". I've performed changes for file_helper, hostname_scan, dns_finder, service_scan and a bit for virtual_host_scanner although you had it pretty much done already. I've made file_helper static as that made the most sense. I'll do the main reconnoitre.py last obviously.

I wanted to get some feedback from you just to know if stuff is going in the direction you expected. Do check it when you get a few minutes to spare.

codingo commented 6 years ago

May be a couple of days until I can do a fulp revies, but I'll update you soon as I can!

codingo commented 6 years ago

Hi @evyatarmeged, just touching base to see where we've landed with this one?

evyatarmeged commented 6 years ago

Hi @codingo,

I've made some refactoring to the project and was waiting for your feedback (see my comment earlier in this issue). I did not want to continue to work without you reviewing the work done so far and pointing me in the direction you want this to go.

Regardless, the fork is now removed since there was no response so I figured this project was not at the top of your list.

Is there anything new from your end?

codingo commented 6 years ago

@evyatarmeged Subfinder/VHostScan have definitely taken attention for a while, but I've been looking at breathing some fresh life into this.

Happy for you to contribute anything you feel would be of benefit to the community as a whole. This project is designed for those going through HackTheBox/OSCP, and anything that can benefit that community I would happily accept as a merge.

bbeale commented 4 years ago

I just submitted a PR to address this issue, but there's a verify-json-validation check that is failing and I'm not able to track it down at a quick glance.