search

codingo / VHostScan

A virtual host scanner that performs reverse lookups, can be used with pivot tools, detect catch-all scenarios, work around wildcards, aliases and dynamic default pages.
GNU General Public License v3.0
1.19k stars 231 forks source link

Colorize Interface #103

Closed maxoja closed 5 years ago

maxoja commented 5 years ago

User can disable this option by entering argument -c FALSE

I used termcolor module https://pypi.org/project/termcolor/ to paint text with colors to improve readability of the interface.

There are some limitation of the module depending on terminal brands which is described in the link above.

I am not confident about the quality of my code. I think it needs a lot further refinement to match the overall quality standard of this repository, so it will be a great favor if you can leave me some comments or guidance about the improvement.

codingo commented 5 years ago

@timkent or I will Will properly review this in a day or two. Feel free to prompt here if we take any longer than that.

codingo commented 5 years ago

Just noticed this failed the automated test cases. Could you resolve and then I'll review?

maxoja commented 5 years ago

Of course, I will resolve it first. I have something to ask. The rejection occurred when it tried to call pep8. Is this failed caused by poor code quality?

maxoja commented 5 years ago

I finally made it through the automated test. Just learned quite a lot of mistakes were in my update ;-;

codingo commented 5 years ago

Sorry for being slow in reviewing this, hoping to get a chance to properly go over this early next week.

linted commented 5 years ago

@maxoja, in my opinion this is great code, good job.

codingo commented 5 years ago

Just touching base to let you know that I'm not ignoring this. I've received quite a lot of pull requests over a few days (a great problem really!). Hoping to have everything up to date by Wednesday evening, but may not get to this until then.

codingo commented 5 years ago

Hi @maxoja, assuming this is still a work in progress?

I've put this into a test bench (blank VM) and run setup, and receive an exception:

Traceback (most recent call last):
  File "/usr/local/bin/VHostScan", line 11, in <module>
    load_entry_point('VHostScan==1.21', 'console_scripts', 'VHostScan')()
  File "/usr/local/lib/python2.7/dist-packages/pkg_resources/__init__.py", line 572, in load_entry_point
    return get_distribution(dist).load_entry_point(group, name)
  File "/usr/local/lib/python2.7/dist-packages/pkg_resources/__init__.py", line 2752, in load_entry_point
    return ep.load()
  File "/usr/local/lib/python2.7/dist-packages/pkg_resources/__init__.py", line 2405, in load
    return self.resolve()
  File "/usr/local/lib/python2.7/dist-packages/pkg_resources/__init__.py", line 2411, in resolve
    module = __import__(self.module_name, fromlist=['__name__'], level=0)
  File "/usr/local/lib/python2.7/dist-packages/VHostScan-1.21-py2.7.egg/VHostScan/VHostScan.py", line 58
    ), end='')
          ^
SyntaxError: invalid syntax
codingo commented 5 years ago

Closing due to inactivity.