codingo / VHostScan

A virtual host scanner that performs reverse lookups, can be used with pivot tools, detect catch-all scenarios, work around wildcards, aliases and dynamic default pages.
GNU General Public License v3.0
1.2k stars 231 forks source link

Pass the virtual_host_scanner constructor arguments as a dict #42

Closed diogoosorio closed 7 years ago

diogoosorio commented 7 years ago

With the current implementation, adding a new input parameter is a three step process:

  1. Add its definition to the ArgumentParser instance
  2. Change the virtual_host_scanner constructor signature
  3. Change the virtual_host_scanner instantiation arguments
  4. Set the instance property value within the virtual_host_scanner

By receiving a dict directly as a constructor argument, steps 2 and 3 become unnecessary.

codingo commented 7 years ago

Thank-you - solid improvement / til more python. Merged!