search

codingo / VHostScan

A virtual host scanner that performs reverse lookups, can be used with pivot tools, detect catch-all scenarios, work around wildcards, aliases and dynamic default pages.
GNU General Public License v3.0
1.19k stars 231 forks source link

Remove need for '-' flag to force stdin #74

Closed codingo closed 6 years ago

codingo commented 6 years ago

This patch removes the need for the '-' flag when using stdin and instead allows you to pipe into VHostScan directly at anytime. STDIN is checked prior to a commit.

Tested already on a Windows VM but still requires testing in Kali.

timkent commented 6 years ago

It seems to work well but now it includes the wordlist as well as the stdin list. I assume this is not the desired result?

codingo commented 6 years ago

I can replicate it, this is the relevant code block:

    default_wordlist = DEFAULT_WORDLIST_FILE \
        if not sys.stdin.isatty() else None

Will look to resolve in the next couple of days unless you have a chance to patch!

codingo commented 6 years ago

Ignore the above - once I posted that I realised it was just in the reverse. Could you please re-test @timkent? The following would ensure good coverage:

  1. STDIN only
  2. STDIN + wordlist
  3. No STDIN, default wordlist
  4. No STDIN, provided wordlist

I'll look at making an automated test case for this area once we've merged this branch.

timkent commented 6 years ago

Looks good, I have tested those scenarios.