codingo / VHostScan

A virtual host scanner that performs reverse lookups, can be used with pivot tools, detect catch-all scenarios, work around wildcards, aliases and dynamic default pages.
GNU General Public License v3.0
1.2k stars 231 forks source link

Wordlist helper #79

Closed gigkokman closed 7 years ago

gigkokman commented 7 years ago

Introducing WordList class in wordlist_helper

codingo commented 7 years ago

I'm travelling at the moment and I'm not sure what @timkent's schedule is looking like so it may be a couple of days before we can test/merge this one!

gigkokman commented 7 years ago

No problem, let me know if you have any suggestion.

codingo commented 7 years ago

Had a chance for a quick look and this is currently failing, results below:

root@kali:~/source/testing/VHostScan# python ./VHostScan.py -t testbench.home +-+-+-+-+-+-+-+-+-+ v. 1.7.1 |V|H|o|s|t|S|c|a|n| Developed by @codingo_ & @__timk +-+-+-+-+-+-+-+-+-+ https://github.com/codingo/VHostScan

Traceback (most recent call last): File "./VHostScan.py", line 119, in main() File "./VHostScan.py", line 35, in main wordlist, wordlist_types = wordlist_helper.get_wordlist(arguments.wordlist) AttributeError: 'Namespace' object has no attribute 'wordlist'

The following tests should pass:

codingo commented 7 years ago

Sorry @gigkokman - there's one bug that was introduced with this. It looks like when you do a pipe it's now appending the default wordlist (when data is passed in pipe it should be treated as if it's the only data).

When you do the following:

echo "test" | python ./VHostScan.py -t <target> --no-lookups You should only see a result for test. At the moment it appends the full default wordlist onto this also.

gigkokman commented 7 years ago

Thanks @codingo, I'll fix and recheck again.

codingo commented 7 years ago

Thank-you @gigkokman! I'm intending on putting in automated test cases for this in future that will help give more immediate feedback - sorry that wasn't the case prior to this pr.

gigkokman commented 7 years ago

@codingo , I add new test case for stdin and wordlist and I think it covers 4 cases above. Let me know if you have another issue.