search

codingteam / emulsion

XMPP ↔ Telegram bridge
MIT License
33 stars 3 forks source link

Use v1 of actions/setup-dotnet #128

Closed Minoru closed 3 years ago

Minoru commented 3 years ago

This avoids the use of deprecated set-env call, and makes sure our workflow stays up-to-date with an upstream version.

(This is intended to fix the build failure in #127.)

ForNeVeR commented 3 years ago

First, I believe it's better to use fixed version (v1 is a volatile one). Second, there's an unrelated NuGet failre I'll fix here, too.

Minoru commented 3 years ago

Sorry, didn't see your comment in time, @ForNeVeR. I'm trying out a suggestion from https://github.com/actions/setup-dotnet/issues/155#issuecomment-748452076, let's see how it goes and then we can close this PR.

Minoru commented 3 years ago

Okay, so that fix works, but I'll leave it to @ForNeVeR to carry this forward :)

ForNeVeR commented 3 years ago

The underlying issue was fixed in a more straightforward way by #129. Thanks though!