search

codingteam / horta-hell

Configurable XMPP bot written in Scala based on the Akka framework.
MIT License
15 stars 8 forks source link

Bugfix/83 #372

Closed hagane closed 8 years ago

hagane commented 8 years ago

A hard fix for #83 I've took a liberty of performing some clean up (namely, dropped an unused Lock from JabberProtocol and organized imports in files i touched), so a scrutinous review is in order

hagane commented 8 years ago

You may want to wait for some time, 'cause there is a slight problem with chat management, btw. Horta can and will sometimes lose first private message, if conversation is initiated by user. I'll fix it when I get (in)sane enough to reason about threading.

hagane commented 8 years ago

All right, I fixed it. I like the end result even better -- no ChatOpened in MucMessageHandler and generally terser code

ForNeVeR commented 8 years ago

I hope I'll be able to review that tonight, thank you.

ForNeVeR commented 8 years ago

I have no complaints about this code. Let's test that!