s/{from}/{to}/ does not check presense of {from} in the message

codingteam / horta-hell

Configurable XMPP bot written in Scala based on the Akka framework.

MIT License

15 stars 8 forks source link

s/{from}/{to}/ does not check presense of {from} in the message #378

Closed ChALkeR closed 8 years ago

ChALkeR commented 8 years ago

It should probably ignore the replacement if nothing was actually changed in the message. A better option: it could search several messages back to find the first matched one.

Current situation:

User: foo
User: bar
User: s/foo/baz/
horta hell: User: bar

Minoru commented 8 years ago

@ForNeVeR, are you still on this? It looks to me like this can be fixed with just a couple lines of code. Should I submit a PR? Am I missing some hidden problems?

ForNeVeR commented 8 years ago

Don't think so. You're free to implement this.