PrivateMucMessageHandler: get rid of nulls

codingteam / horta-hell

Configurable XMPP bot written in Scala based on the Akka framework.

MIT License

15 stars 8 forks source link

PrivateMucMessageHandler: get rid of nulls #381

Closed ForNeVeR closed 8 years ago

ForNeVeR commented 8 years ago

I've been researching #98 a bit and found that we have these null checks everywhere we trying to get message.getBody. Smack seems to be sometimes using these "messages" to signal about various non-message events, so we need to filter that shit.

I wasn't able to reproduce the bug (because it's triggered by some specific XMPP messages we're still not aware about), but I am pretty confident that's the core reason. Just filter these nasty nulls on the outer side of our API.

Closes #98.

rexim commented 8 years ago

Changes look fine for me. Thanks! The shit is approved.

ForNeVeR commented 8 years ago

Thank you.