search

codingteam / pacmacs.el

Pacman for Emacs
Other
91 stars 9 forks source link

Rework nick after death #193

Closed rexim closed 8 years ago

ForNeVeR commented 8 years ago

Well, looks good to me. Please fix the unit tests and make changes you mentioned in the comments. You're free to merge it afterwards.

rexim commented 8 years ago

Thank you mr @ForNeVeR! You're the best! :)

ForNeVeR commented 8 years ago

It seems that you're changing much more that I expected. Please notify me if you need my help to review this again after all these changes.

rexim commented 8 years ago

@ForNeVeR yep, that's true. I just wanted to slightly refactor that mess and ended up removing everything. I really need to get this reviewed after I finish everything. So, once I'm done I will reassign this to you for an additional review. Thanks!

rexim commented 8 years ago

@ForNeVeR, Sending back for an additional review. Thanks!

ForNeVeR commented 8 years ago

I've finished with the review, it looks good.

rexim commented 8 years ago

More tanks for you mr @ForNeVeR :3