Implement internal image format

codingteam / pacmacs.el

Pacman for Emacs

Other

91 stars 9 forks source link

Implement internal image format #212

Closed rexim closed 8 years ago

rexim commented 8 years ago

Should close #208

rexim commented 8 years ago

@ForNeVeR please read https://github.com/codingteam/pacmacs.el/commit/3bf437afac98d494ee38779efa324c6a3f70e50e before the review

ForNeVeR commented 8 years ago

Well, overall it's okay. Feel free to notify me, if you want me to review that again after the refactoring you mentioned.

rexim commented 8 years ago

Thank you very much Mr @ForNeVeR!

rexim commented 8 years ago

Well, switching the notation for pacmacs-image didn't actually change the code too much. Don't think any additional review is required. I'm merging the PR.

ForNeVeR commented 8 years ago

Ok!