search

codingteam / pacmacs.el

Pacman for Emacs
Other
91 stars 9 forks source link

Implement ImageMagick pixel enumeration parser #217

Closed rexim closed 8 years ago

rexim commented 8 years ago

Close #216

rexim commented 8 years ago

@rexim also don't forget to check that probably a dash.el bug that you found on the stream

ForNeVeR commented 8 years ago

@rexim please evaluate if this PR will require to change our Melpa recipe.

rexim commented 8 years ago

@ForNeVeR since #216 is a subtask of #41 (see https://github.com/codingteam/pacmacs.el/issues/41#issuecomment-180957182) we don't need to update MELPA recipe right now. But we definitely need to change it if the outcome of #41 will be positive. We need to keep track of such things somehow. I think I will create an issue for that.

ForNeVeR commented 8 years ago

Acknowledged.

rexim commented 8 years ago

@ForNeVeR fixed all the remarks. Please verify.

rexim commented 8 years ago

Sorry, assigning back to myself. Please see https://github.com/codingteam/pacmacs.el/issues/218#issuecomment-180975075. I need to change the Cask file to include those sprites/*.txt files. Let's keep track of the MELPA recipe changes in our Cask file.

rexim commented 8 years ago

@ForNeVeR done. Please, review now. :)

ForNeVeR commented 8 years ago

LGTM :+1:

rexim commented 8 years ago

Thank you Mr @ForNeVeR