search

codingteam / pacmacs.el

Pacman for Emacs
Other
91 stars 9 forks source link

Replace deprecated dash-functional dependency #224

Closed basil-conto closed 3 years ago

basil-conto commented 3 years ago

Dash 2.18.0 now subsumes dash-functional.

See https://github.com/magnars/dash.el/blob/master/NEWS.md#from-217-to-218

coveralls commented 3 years ago

Coverage Status

Coverage decreased (-0.1%) to 42.01% when pulling ee83af998d586ccf0ae93e86a1d8e4646869eb00 on basil-conto:blc/dash into d813e9c62c2540fe619234824fc60e128c786442 on codingteam:master.

rexim commented 3 years ago

@ForNeVeR jfyi, I think this is some sort of dependabot-like bot. They submitted literally the same PR to https://github.com/rexim/ebf/pull/27 and many other Emacs repos.

basil-conto commented 3 years ago

@ForNeVeR jfyi, I think this is some sort of dependabot-like bot. They submitted literally the same PR to rexim/ebf#27 and many other Emacs repos.

@rexim No, this is one of the very real maintainers of the dash package who is trying to speed up the deprecation of dash-functional by helping downstream packages upgrade their dependencies. You're welcome ;).

rexim commented 3 years ago

@basil-conto oh shi, I'm sorry! :D It just looked a bit sus. Thank you for doing this work! :heart: I'll take a look at your PRs when I get a chance. (next week Thursday most likely)

basil-conto commented 3 years ago

@rexim No worries, not the first time I've been called a bot ;). There's no hurry on my end, take your time - my PRs are just a heads-up. Thanks for working on these cool packages!

ForNeVeR commented 3 years ago

The current plan is:

  1. I'll try to prepare a Chocolatey package for Cask (which looks like it should work on Windows, so why not: I won't need to bother to start another machine, and will make a small but potentially useful contribution to the ecosystem)
  2. I'll ensure that Pacmacs isn't broken by the change
  3. I'll merge

Thanks for the contribution!

ForNeVeR commented 3 years ago

Bah the eventual consistency.

@rexim, if you wanna to manage this yourself, then you're very welcome. I'll only work on Cask part, then; everything else's up to you.

Have fun!

rexim commented 3 years ago

@ForNeVeR yep, on Thursday I planned to

Is that fine with you?

P.S. The Chocolatey package could be a separate issue.

basil-conto commented 3 years ago

Check if PR does not break anything

When looking into this, make sure that both dash/dash-functional are indeed up to date, to avoid inconsistency issues like those caused by MELPA's versioning scheme. E.g. 20190101 is a larger number than 2.18.0, but the latter is newer. This came up recently in emacs-lsp/lsp-mode#2622.

Installing dash from the package-archives default of https://elpa.gnu.org/packages/, or even https://elpa.gnu.org/devel/, should in theory be an easy way to avoid these issues.

HTH.

rexim commented 3 years ago

@basil-conto I checked everything in an isolated environment using cask and double checked the version of dash. It was specifically 2.18.0.

@ForNeVeR I checked this PR on Linux Emacs 27.1 everything works, nothing is broken. I'm merging this PR. Feel free to create a separate issue for the Chocolatey package you wanted to implement.

basil-conto commented 3 years ago

Thanks!