codingteam / pacmacs.el

Pacman for Emacs
Other
92 stars 9 forks source link

Handle properly situations when the image displaying is not supported. #39

Open rexim opened 9 years ago

rexim commented 9 years ago

http://www.gnu.org/software/emacs/manual/html_node/elisp/Display-Feature-Testing.html

rexim commented 9 years ago

I didn't decide yet what we should do in case of unsupported image displaying. We can close the game with the corresponding message or we can fallback to ascii graphics. Using the fallback to ascii graphics may help to fix #38

Minoru commented 9 years ago

On Sun, Sep 06, 2015 at 12:49:14PM -0700, Alexey Kutepov wrote:

We can fail

"Here's a nickel, kid; go buy yourself a graphics-capable computer."

If you will insist on supporting ASCII, I will insist on supporting Braille as well :P

Seriously, though, I think you shouldn't stretch yourself too thin. Failing is fine. You can deal with ASCII later, if you're so inclined.

Regards, Alexander Batischev

rexim commented 9 years ago

"Here's a nickel, kid; go buy yourself a graphics-capable computer."

It's not about the hardware. Many people use Emacs in a bare console. Also I hoped that ASCII would help us to fix #38 but I already closed that issues because I thought that it's too much responsibility for the unit tests.

You can deal with ASCII later, if you're so inclined.

Of course I will do this later! That's why I've put the backlog label on it. :)

Also, since #38 is closed I think we'll stick with the "failing" scenario. But I don't wanna plan this issue on the 5th Tsoding because I want to have something playable as soon as possible. So I plan only tasks that are essential for getting us there. :)

Minoru commented 9 years ago

On Sun, Sep 06, 2015 at 01:40:06PM -0700, Alexey Kutepov wrote:

"Here's a nickel, kid; go buy yourself a graphics-capable computer."

It's not about the hardware. Many people use Emacs in a bare console.

I was only kidding ;)

Regards, Alexander Batischev

rexim commented 9 years ago

I was only kidding ;)

ok :)

rexim commented 9 years ago

By the way, the ASCII fallback could be useful for Integration Testing on Travis #77