Open codingtuto opened 1 day ago
Hi Codingtuto and Team,
Thank you for taking the time to address these concerns and for outlining a path forward. I completely understand the need for consistency and alignment within the team, and I genuinely appreciate the feedback regarding the TypeScript rewrite.
When I decided to rewrite the codebase in TypeScript, my intention was to leverage the additional type safety and tooling support it provides, which I believed could enhance the long-term maintainability of the project. However, I acknowledge that this was a significant shift, and I should have initiated more discussion with the team before making such a major decision. I apologize if this caused any disruption or misalignment.
Regarding the proposal, I agree that:
Lastly, I want to reaffirm my commitment to the project and the team. I value everyoneās efforts, including Bakarās feature additions, and Iām looking forward to collaborating closely to improve LiteJsonDb together.
Let me know how I can help with the next steps.
Best regards, Doni
š Hey @DoniLite
First offāno need to apologize. Really. You took the initiative, rewrote the entire codebase, and submitted a pull request. Thatās real work! Compare that to the usual āIāll totally contribute soonā crowdāyou know who you are šāand youāre already ahead. So, hats off to you for showing both skill and commitment.
Now, onto TypeScript. I get itātype safety, better tooling, fewer late-night debugging disasters. Itās a solid choice, and I can see where you were coming from. But hereās the deal: weāve got five other contributors actively coding right now, and theyāre all in Node.js native. Thatās our teamās happy place at the moment, and consistency is key. So for now, letās stick to what works for the majority, and revisit TypeScript later, maybe when the dust settles.
I really appreciate your willingness to align with the team direction, especially regarding the Python features migration. Between your skills, Bakarās features (which weāll modularize soon, promise!), and a bit more coordination, weāve got everything we need to take LiteJsonDb to the next level. š
Also, to everyone lurking: Doniās out here putting in the workāwhatās your excuse? š
Letās make this happen. Looking forward to the next steps!
Thanks for the kind words and clear direction! I completely understand the need for consistency, and Iām all in for sticking to Node.js native for now. Iāll start reviewing the Python features we could prioritize for migration, and Iām here to help with modularizing Bakarās features as well.
Letās keep the momentum goingāexcited to see how far we can take LiteJsonDb together! š
š Hi team,
Iām taking over the development of the Node.js version of LiteJsonDb, and I wanted to address some concerns about where weāre heading.
To be honest, things arenāt in great shape right now. The original codebase was more structured, which made it easier to maintain and build upon. Unfortunately, some of the recent changes have made the project harder to manage.
For example, Bakarās pull request introduces some great features (props for that), but it lacks clear architecture and modularity. This has kept the changes from being included in a release so far, despite the effort involved.
On the other hand, Doni rewrote the entire codebase in TypeScript in another pull request. While TypeScript has its benefits, this decision seems to have been made without much discussion, and itās a significant shift from the Node.js native approach most of us have been following. We need consistency in our tools and workflow to stay efficient as a team.
Lastlyāand letās be realāthe Python version of LiteJsonDb is far ahead of the Node.js version. This gap is something we need to address, as itās holding us back.
Hereās what I propose:
This isnāt about pointing fingersāBakar and Doni, your contributions are appreciated. But we need to take a step back, refocus, and tackle the bigger picture to move the project forward.
What do you all think? Iām here to discuss and figure out the best way forward together.
Letās fix this together!