search

codinguser / gnucash-android

Gnucash for Android mobile companion application.
Apache License 2.0
1.23k stars 540 forks source link

Hourly backup schedules set as monthly #625

Closed schvabodka-man closed 7 years ago

schvabodka-man commented 7 years ago

Steps to reproduce the behaviour

  1. Set hourly schedule for importing to cloud
  2. Click export
  3. It will set to monthly, not the hourly

Screenshots

alt tag alt tag alt tag

Expected behaviour

Hourly schedule is actually setting to hours

Actual behaviour

Hourly schedule is setting to monthly, not the hourly

Software specifications

codinguser commented 7 years ago

@schvabodka-man We do not handle hourly schedules at the moment. But since the dialog is generated through a library, there was no easy way to remove it from the UI.

We could consider implementing an hourly schedule if there is demand for that. This is the first request I've had on that. What do you think @rivaldi8 ?

rivaldi8 commented 7 years ago

@codinguser I'm not sure. At least now, it seems to me that it would add complexity for little benefit. I'd like to know some use cases for it first. We are also still having issues with scheduled exports and missing other features like specifying multiple weekdays. So again, I'd rather define first what features we want to support to help decide how to deal with the whole thing.

@schvabodka-man why do you need to export hourly?

schvabodka-man commented 7 years ago

Because i like to have hourly backups obliviously

codinguser commented 7 years ago

@rivaldi8 I agree with you, priority should be on fixing the existing bugs. But we have HOURLY in the UI as well. My preference would be to remove it from there and not have to deal with it.

But at the moment, someone could set a schedule for hourly backup and then proceed to delete a book thinking they have a backup, only to find themselves very mistaken. That would be on us.

rivaldi8 commented 7 years ago

@codinguser Is it even possible to remove the hourly recurrence option from this dialog? There's no documentation and, after a quick look at the code, I can't see how to do so.

codinguser commented 7 years ago

I'm not sure that it's possible. I remember looking for it in the docs once, and also exploring the code a bit.

Unless something has changed in newer versions, no, it's not possible.

On Mon, 16 Jan 2017 at 18:06, Àlex Magaz Graça notifications@github.com wrote:

@codinguser https://github.com/codinguser Is it even possible to remove the hourly recurrence option from this dialog? There's no documentation and, after a quick look at the code, I can't see how to do so.

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/codinguser/gnucash-android/issues/625#issuecomment-272916460, or mute the thread https://github.com/notifications/unsubscribe-auth/AAQ42yeRkdyyW8DzrJ8SNJd1K3pB3JTgks5rS6OvgaJpZM4LIH4y .

rivaldi8 commented 7 years ago

Then, if it's something we can't workaround easily, I'd try to fix #641, which might make it easier to implement hourly schedules. Otherwise, we'll have to look harder into finding out how to remove the option.

codinguser commented 7 years ago

@rivaldi8 so you can go ahead with #641 given the latest roadblock on the Storage Access Framework