codinguser / gnucash-android

Gnucash for Android mobile companion application.
Apache License 2.0
1.23k stars 540 forks source link

Preserve report type accross rotation #645

Closed GianpaMX closed 7 years ago

GianpaMX commented 7 years ago

Not sure if this is the best way to avoid the crash but for an unknown reason the onAttachFragment() is being called from parent's onCreate()

codinguser commented 7 years ago

Thanks for the PR @GianpaMX So I'm unsure from what you wrote: Does this fix the crashing or not? Also, could you send the PR against the develop branch. We never merge anything directly into master

GianpaMX commented 7 years ago

Yes this fixes the crashing. I'm closing this PR and opening a new one against develop; just code review it before merging to make sure the solution makes sense