codinguser / gnucash-android

Gnucash for Android mobile companion application.
Apache License 2.0
1.23k stars 540 forks source link

Preserve report type across rotation #647

Closed GianpaMX closed 7 years ago

GianpaMX commented 7 years ago

For an unknown reason the onAttachFragment() is being called from parent's onCreate()

This fix makes sure the report type is preserved across rotation so when the updateReportTypeSpinner() is called it does nothing because there is no changes in the report type

nachoparker commented 7 years ago

This message was created automatically by mail delivery software.

A message that you sent could not be delivered to one or more of its recipients. This is a temporary error. The following address(es) deferred:

pkbrister@zoho.com Domain ownyourbits.com has exceeded the max emails per hour (3/3 (100%)) allowed. Message will be reattempted later

------- This is a copy of the message, including all the headers. ------ Received: from github-smtp2-ext2.iad.github.net ([192.30.252.193]:35288 helo=github-smtp2b-ext-cp1-prd.iad.github.net) by skywalker.onesite.co with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.87) (envelope-from noreply@github.com) id 1cVhUf-002Vhh-6J for nacho@ownyourbits.com; Mon, 23 Jan 2017 11:29:21 -0500 Date: Mon, 23 Jan 2017 08:28:40 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1485188920; bh=EbLbbqT/qiwEwZWNyM5OJ1IzoWVr7h6iHQYfYZqk01c=; h=From:Reply-To:To:Cc:Subject:List-ID:List-Archive:List-Post: List-Unsubscribe:From; b=f9wXp/XsO2J7xMRM86uAiqH3yd8tpT4kTsZ/8uRIYJpL5aH67kZLJXM94ZFana5Cm bQILdU2/1dX+N8yyH7D0AXIMHUJnyKjZt+vZCJ/eUqNtispjRj+E3qWWhqUvByi/Ka Jrg+F3upQTStpq6pjG0v6lI+9HrzMbGn9+ec7RwA= From: Juan Villa notifications@github.com Reply-To: codinguser/gnucash-android reply@reply.github.com To: codinguser/gnucash-android gnucash-android@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Message-ID: codinguser/gnucash-android/pull/647@github.com Subject: [codinguser/gnucash-android] Preserve report type across rotation (#647) Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="--==_mimepart_58862f388f4b2_7d1a3f91a20df13829117"; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: list X-GitHub-Sender: GianpaMX X-GitHub-Recipient: nachoparker X-GitHub-Reason: subscribed List-ID: codinguser/gnucash-android List-Archive: https://github.com/codinguser/gnucash-android List-Post: mailto:reply@reply.github.com List-Unsubscribe: mailto:unsub+0145ac5c449185f8c31cc418dbc2e3a897662e2c69541be392cf00000001149df13892a169ce0c132999@reply.github.com, https://github.com/notifications/unsubscribe/AUWsXMUrtPnE85UEg8EUuBxd5qse5il8ks5rVNU4gaJpZM4LrP-Z X-Auto-Response-Suppress: All X-GitHub-Recipient-Address: nacho@ownyourbits.com

----==_mimepart_58862f388f4b2_7d1a3f91a20df13829117 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit

For an unknown reason the onAttachFragment() is being called from parent's onCreate()

This fix makes sure the report type is preserved across rotation so when the updateReportTypeSpinner() is called it does nothing because there is no changes in the report type

-- Commit Summary --

-- File Changes --

M app/src/main/java/org/gnucash/android/ui/report/ReportsActivity.java (13)

-- Patch Links --

https://github.com/codinguser/gnucash-android/pull/647.patch https://github.com/codinguser/gnucash-android/pull/647.diff

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/codinguser/gnucash-android/pull/647

----==_mimepart_58862f388f4b2_7d1a3f91a20df13829117 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit

For an unknown reason the onAttachFragment() is being called from parent's onCreate()

This fix makes sure the report type is preserved across rotation so when the updateReportTypeSpinner() is called it does nothing because there is no changes in the report type


You can view, comment on, or merge this pull request online at:

  https://github.com/codinguser/gnucash-android/pull/647

Commit Summary

File Changes

Patch Links:


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

----==_mimepart_58862f388f4b2_7d1a3f91a20df13829117--

codinguser commented 7 years ago

thanks @GianpaMX