search

codinguser / gnucash-android

Gnucash for Android mobile companion application.
Apache License 2.0
1.23k stars 540 forks source link

Hourly schedules #678

Closed pankaramp closed 7 years ago

pankaramp commented 7 years ago

Needs review

Hi, I've implemented hourly scheduled actions, and tested them to work by creating an hourly Dropbox export. There are three notes, however: a) I've not implemented changes related to Budgets. Unfortunately some of these methods were difficult to understand with my limited GnuCash experience. I believe this feature is not production-ready yet? I've marked all spots where code needs to be filled in with the comment TODO:HOUR. b) I changed the AlarmManager interval for ScheduledActionService from HALF_DAY to HALF_HOUR, i.e. form half the old minimum unit to half the new minimum unit. I hope this does not impact battery drain, etc. c) I've added new strings to the English resource file, however I've not copied them over to other locale files.

Best regards, Panos.

codinguser commented 7 years ago

Hey @laugh-at-me , thanks for the PR. However, this functionality is already implemented in the develop branch - see #625 . (and yes, Budgets is not production ready yet)

Please always check for the existing issues in the issues list to see if anyone is working on something before taking it on. If an issue does not exist for something you want to work on, then you can create an issue so that the community can weigh in before you start work. Also that way, everyone knows what you're working on and we can avoid duplicate work.

Also, current development work is done in the develop branch, not in master. Master only points to the last stable release. See our contribution guidelines.

I hope you keep contributing (we have lots of issues to be worked on). But for now, I will close this pull request. Cheers,