Extended calculator keyboard

yohji commented 7 years ago

This pull request is in response to the enhancement issue #725 . It concerns the calculator keyboard:

introduced a new key on the keyboard indicated by "T", that it fills the amount with the total (balance) of the current account.
fixed the getBalance() of Money; it loses the value of the incremental adding from iteration.
fixed the "C" in the landscape res; it points to the "back".

codinguser commented 7 years ago

@yohji Thanks for the PR. I will evaluate this PR soon and give you feedback.

codinguser commented 6 years ago

@yohji I was just going through the PR again. Sorry for the delay in reviewing it.

A few points:

The symbol on the button (looks like a "T") does not immediately convey what that button does and is thus very opaque.
As a consequence of the previous point, I was thinking about how often that button would be used. I think not very often, (indeed you mentioned in #725 that it is useful mostly for emptying the account in favor of another one). This is not something that I anticipate would happen often and therefore I do not think it is worth it to have an extra button in the UI for that.

I'm sorry, I don't think I will be merging this.
Thank you for the effort you put into making GnuCash Android better. Keep the feedback coming!

Cheers,

codinguser / gnucash-android