search

codinguser / gnucash-android

Gnucash for Android mobile companion application.
Apache License 2.0
1.23k stars 540 forks source link

text margins for RTL text in transaction details screen #791

Closed pnemonic78 closed 6 years ago

pnemonic78 commented 6 years ago

fixes #790

pnemonic78 commented 6 years ago

Don't confuse RTL content with RTL layouts. android:layout_marginStart is "left" to LTR layouts, but "right" for RTL layouts. For example, the "x" button appears on top-left in LTR layout, but will be in top-right in RTL layout => title margin should be on left => margin should be "end".

Cannot just add android:supportsRTL without checking that all the screens are still OK.