search

codinguser / gnucash-android

Gnucash for Android mobile companion application.
Apache License 2.0
1.23k stars 539 forks source link

#876 Major contribution to gnucash-android #882

Open JeanGarf opened 4 years ago

JeanGarf commented 4 years ago

Hi,

This is one of my main contribution to GnucashAndroid.

It corrects #876, but also lots of other errors like

You can see all my contributions together on the following branch : https://github.com/JeanGarf/gnucash-android/tree/tw_develop

If you want to get the corresponding apk, you can get it on my web site : http://thierryw777.free.fr/index.php/bureautique/comptabilite/gnucash-android/

See you,

strixaluco commented 4 years ago

Thank you for your contribution, @JeanGarf. I immediately thought about writing to @codinguser about your PR, have you tried getting in touch with him, possibly by email or other means? We can't let this solid amount of work be stuck in limbo.

JeanGarf commented 4 years ago

Hi strixaluco,

Yes I tried to send email to @codinguser, but I didn't get any response.

I'm new to contribute to open source project and to Android and therefore I don't know what to do.

I can perhaps upload the apk corresponding to my cumulative tw_develop branch, but I don't if it is a good idea or not ?

strixaluco commented 4 years ago

It's a pity there was no response. I've also replied on his tweet about GnuCash from about 3 years ago, mentioning stalled PRs, but who knows if that will have any effect. I'm sure that GitHub lurkers like us will appreciate your own build, but that doesn't seem like sustainable solution given the fact, that there's no way to submit updates to Google Play. Maybe people from the main GnuCash team can give us a hint on the best way forward.

strixaluco commented 4 years ago

Seems that another contributor managed to reach @codinguser and he promised to look into merging all the PRs.

JeanGarf commented 4 years ago

Hi @strixaluco

I added a page on my web site to allow downloading of the apk with all my contributions http://thierryw777.free.fr/index.php/bureautique/comptabilite/gnucash-android/

If you're interested to test or use it, tell me if it works fine.

See you

strixaluco commented 4 years ago

Really appreciate your efforts, @JeanGarf. Will try your build and will report if anything.

Thumas commented 4 years ago

The enhancements are pretty useful! But you didn't adjust the UI tests to your new searchable spinner. Running a slightly adjusted multi-currency test reveals that your spinner seems to trigger the onItemSelectedListener even if you only search for an account without actively selecting it.

  1. Add three accounts with different currencies to an empty database.
  2. Select one of them, create a new transaction.
  3. Enter a value
  4. Click on the transaction account, then your searchable spinner appears.
  5. Enter something that does not trigger the automatic choice and then delete it completely.
  6. The transfer funds dialog appears, although you didn't select an account yet.
JeanGarf commented 4 years ago

The enhancements are pretty useful! But you didn't adjust the UI tests to your new searchable spinner. Running a slightly adjusted multi-currency test reveals that your spinner seems to trigger the onItemSelectedListener even if you only search for an account without actively selecting it.

1. Add three accounts with different currencies to an empty database.

2. Select one of them, create a new transaction.

3. Enter a value

4. Click on the transaction account, then your searchable spinner appears.

5. Enter something that does not trigger the automatic choice and then delete it completely.

6. The transfer funds dialog appears, although you didn't select an account yet.

I Thumas,

I'm sorry, I'm very new to android dev and I didn't success to run UI tests. I even had to remove lines 173 to 178 (spoon) in app/build.gradle in order to compile ! I don't know why.

Could you explain me how to make them work ?

Thanks

aramaicus commented 3 years ago

Hi @strixaluco

I added a page on my web site to allow downloading of the apk with all my contributions http://thierryw777.free.fr/index.php/bureautique/comptabilite/gnucash-android/

If you're interested to test or use it, tell me if it works fine.

See you

Could you please re-upload the apk? The link from Google Drive isn't working.

JeanGarf commented 3 years ago

Hi @strixaluco I added a page on my web site to allow downloading of the apk with all my contributions http://thierryw777.free.fr/index.php/bureautique/comptabilite/gnucash-android/ If you're interested to test or use it, tell me if it works fine. See you

Could you please re-upload the apk? The link from Google Drive isn't working.

Hi, I'm sorry, I made a small change in the app and forget to update my link.

Could you try again and tell me if it works fine ?

See you

P.S. : The change is in the Account chooser is the following : When you type characters in the search field, account list is filtered. If only one account remains in the filtered list, it is not automatically selected anymore. You have to click on it to choose it. This allows you to check that this really the account you want to select.

albert2004 commented 3 years ago

Version available in provided link have one issue to me. When I use my currency (PLN) and provide amount in transaction, for example 130,67PLN it works fine. But when I enter transaction again for edit, amount is rounded (131PLN). This was not happening with official version. I write it here, since I don't see "issues" section in your fork - maybe disabled on purpose ;)

aramaicus commented 3 years ago

I've got the same issue: it rounds the values. If I put $1.98, it rounds to $2.

On Fri, May 28, 2021, 06:16 albert2004 @.***> wrote:

Version available in provided link have one issue to me. When I use my currency (PLN) and provide amount in transaction, for example 130,67PLN it works fine. But when I enter transaction again for edit, amount is rounded (131PLN). This was not happening with official version. I write it here, since I don't see "issues" section in your fork - maybe disabled on purpose ;)

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/codinguser/gnucash-android/pull/882#issuecomment-850277278, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUBJL5J465IRGV3MGKQUUQLTP5NPXANCNFSM4OCZXQ7A .

JeanGarf commented 3 years ago

Version available in provided link have one issue to me. When I use my currency (PLN) and provide amount in transaction, for example 130,67PLN it works fine. But when I enter transaction again for edit, amount is rounded (131PLN). This was not happening with official version. I write it here, since I don't see "issues" section in your fork - maybe disabled on purpose ;)

Hi, thank for reporting this issue. I also have the same problem. I'll correct it in the following weeks.

See you

JeanGarf commented 3 years ago

Version available in provided link have one issue to me. When I use my currency (PLN) and provide amount in transaction, for example 130,67PLN it works fine. But when I enter transaction again for edit, amount is rounded (131PLN). This was not happening with official version. I write it here, since I don't see "issues" section in your fork - maybe disabled on purpose ;)

Hi albert2004 and aramaicus,

I've corrected my mistake. You can get the corrected apk on my web site here :

http://thierryw777.free.fr/index.php/bureautique/comptabilite/gnucash-android/

Thanks for having reported the issue.

Bye

aramaicus commented 3 years ago

Hi JeanGarf. I've already downloaded. I'll test it and report you any issue.

I'm glad to help.

Thank you for keeping Gnucash for Android alive.

On Thu, Jun 10, 2021, 17:18 JeanGarf @.***> wrote:

Version available in provided link have one issue to me. When I use my currency (PLN) and provide amount in transaction, for example 130,67PLN it works fine. But when I enter transaction again for edit, amount is rounded (131PLN). This was not happening with official version. I write it here, since I don't see "issues" section in your fork - maybe disabled on purpose ;)

Hi albert2004 and aramaicus,

I've corrected my mistake. You can get the corrected apk on my web site here :

http://thierryw777.free.fr/index.php/bureautique/comptabilite/gnucash-android/

Thanks for having reported the issue.

Bye

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/codinguser/gnucash-android/pull/882#issuecomment-859017640, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUBJL5NUZQKIX5RBN6ZPAJLTSEMYVANCNFSM4OCZXQ7A .

albert2004 commented 3 years ago

Hi JeanGarf, I built from sources with fix. Also I corrected one language typo. For Android banking I do not except anything more. Finally it works like it should. Good luck with push!

aramaicus commented 3 years ago

Unfortunately Gnucash-dev crashes a lot more than the Playstore version. At least in my phone Moto G100 Android 11 64 bits.

It crashes a lot but doesn't let me crash report it.

I am not a dev so I am not sure what is the matter here.

On Thu, Jun 10, 2021, 17:24 albert2004 @.***> wrote:

Hi JeanGarf, I built from sources with fix. Also I corrected one language typo. For Android banking I do not except anything more. Finally it works like it should. Good luck with push!

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/codinguser/gnucash-android/pull/882#issuecomment-859025456, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUBJL5P4236UBMJ356H53HLTSENQFANCNFSM4OCZXQ7A .

aramaicus commented 3 years ago

I have and file created on Gnucash on Android 2 years ago. That file works with Gnucash desktop but doesn't work with Gnucash for Android.

When I try to open it, I receive that message:

"An error occurred while importing the GnuCash accounts Unable to parse transaction time - 2019-03-31 15:00:13"

I'm using GnucashAndroid_v2.4.1-dev4_535f3d53.apk

I don't mind sharing that file. There is no confidential information in it.

If you care about it, make me know so I'll send you the file.