search

codinguser / gnucash-android

Gnucash for Android mobile companion application.
Apache License 2.0
1.23k stars 539 forks source link

migrated to androidx, update build dependencies, add drawer menu item… #887

Closed matkovic closed 4 years ago

matkovic commented 4 years ago

… for showing/hiding values

I added a small part of code, where you can click on drawer menu item to show/hide account or transaction values. Similar to other mobile bank applications - the idea is to not let others around you to see your transactions.

Main code changes are in TransactionsActivity.java, BaseDrawerActivity.java, nav_drawer_menu.xml. Changes in other files were auto generated, since I had some problems with dependencies.

I'm not sure if any pull request will be accepted in the future, but anyway here is a small part from me.

arozaqf commented 4 years ago

We need to unify the fork

JeanGarf commented 4 years ago

Hi

I added a page on my web site to allow downloading of the apk with all my contributions (10 Pull Requests) http://thierryw777.free.fr/index.php/bureautique/comptabilite/gnucash-android/

If you're interested to test or use it, tell me if it works fine.

If you know how to merge them into an official version, I would be glad.

See you

Thumas commented 4 years ago

I also did some work, but based on the development branch of @JeanGarf's fork. I was reluctant to submit a pull request, because the UI tests did not pass. @codinguser seems to have abandoned this project, so maybe we should use @JeanGarf's fork as new basis. I don't know if that conforms with the common etiquette on GitHub, though.

matkovic commented 4 years ago

Hey, I'll check @JeanGarf 's fork and maybe create PR on his version, since it is ahead of this and other PRs. I'm not sure if this is the best solution for this "dying" project, but anyway I will leave this PR open and close it after some time, if there will not be a response from original author