codingwell / codingwell-vscode-jscad

VSCode Extension to preview JSCADv2 scripts
MIT License
6 stars 3 forks source link

Require support #1

Closed ku3mich closed 6 months ago

ku3mich commented 8 months ago

added basic require support to be able to handle complex models, updated version of package to recent

tsuckow commented 8 months ago

I'll try to look at this more next week. Could you explain how this is an improvement over previewing a folder?

tsuckow commented 8 months ago

Not that it really matters, but ever tried blueprint.js ? It's a pretty sweet alternative to bootstrap

tsuckow commented 7 months ago

I've had decent luck integrating webpack into the plugin and having it package the code for the webview. I'll try to put a bow on it so we don't need to regex for require. Then integrate your react, etc, changes.

tsuckow commented 7 months ago

I'm liking what I'm seeing from integrating webpack.

I've also been working on adding detection of no change (format on save triggers a false positive change event).

I think my effort covers what you were doing with require(), so I just need to clean things up then I can push an update then start integrating your other changes.

tsuckow commented 7 months ago

Gonna start looking into incorporating some of your other changes, however I did release 0.5 which should cover what you were trying to do with the "require support".

tsuckow commented 6 months ago

I continue to make progress on incorporating the react + download button changes. Unfortunately my schedule is pretty slammed, so I can only occasionally find time to work on it.

tsuckow commented 6 months ago

I haven't forgotten about you but my schedule has been packed.

I reworked some of your changes to the download button to be more straightforward. Next time I get a moment I should be able to check for bugs, update the documentation and cut a new release

tsuckow commented 6 months ago

All the changes should be available in 0.6. I ended up cherry picking so these commits are not included verbatim.