search

codingwell / scala-guice

Scala extensions for Google Guice
Apache License 2.0
341 stars 44 forks source link

Provide optional access to existing bindings on Injector #51

Closed jw3 closed 8 years ago

jw3 commented 8 years ago

Please consider this change which adds optional access to existing bindings on an Injector.

nbauernfeind commented 8 years ago

Aside from the comment, this is looking great.

tsuckow commented 8 years ago

Thanks for spear heading this Nate. It will probably be next week before I can review since I'll be busy with barns& noble maker faire this weekend.

jw3 commented 8 years ago

Updated, added annotation variants.

nbauernfeind commented 8 years ago

This looks great to me. I don't have merge/release credentials, so you'll have to wait for Thomas to get it into maven central.

jw3 commented 8 years ago

Ok, great. Thanks

tsuckow commented 8 years ago

Published 4.0.1-SNAPSHOT, take it for a spin and I'll see about a release next week if you give it the thumbs up.

jw3 commented 8 years ago

Looks good other than I found an additional use case requiring the key to be computed externally, ie

def existingBinding[T: Manifest](key: => Key[T])

https://github.com/jw3/scala-guice/commit/19228a74fe967a036d37525e6e79a0fd942e9759

Submit new PR, or reopen this one?

tsuckow commented 8 years ago

Either way should be fine as long as you don't rewrite history.

On Sat, Nov 7, 2015, 05:53 John Wass notifications@github.com wrote:

Looks good other than I found an additional use case requiring the key to be computed externally, ie

def existingBinding[T: Manifest](key: => Key[T])

Submit new PR, or reopen this one?

— Reply to this email directly or view it on GitHub https://github.com/codingwell/scala-guice/pull/51#issuecomment-154707406 .

jw3 commented 8 years ago

52 submitted, thanks.