Use TypeTag's mirror to prevent problems with Play framework dev mode

codingwell / scala-guice

Scala extensions for Google Guice

Apache License 2.0

341 stars 44 forks source link

Use TypeTag's mirror to prevent problems with Play framework dev mode #78

Closed skress closed 5 years ago

skress commented 5 years ago

This change helps to prevent problems with libraries that mess around with the classloader (e.g. Play framework's dev mode).

This will fix https://github.com/codingwell/scala-guice/issues/77.

tsuckow commented 5 years ago

Status update. Working on regression tests. I first tried using ASM to put stuff in a different classloader which was a failure. Now I am using Scala toolbox which seems promising.

tsuckow commented 5 years ago

Published a 4.2.3 with this PR. I coudn't figure out how to make a unit test for this, I suspect the fix is incomplete but if no one runs into to it then who cares.