Replace uses of Manifest with ClassTag / TypeTag

codingwell / scala-guice

Scala extensions for Google Guice

Apache License 2.0

341 stars 44 forks source link

Replace uses of Manifest with ClassTag / TypeTag #80

Closed ashleymercer closed 5 years ago

ashleymercer commented 5 years ago

The Manifest class is part of the pre-2.10 reflection API, which has been replaced with the newer ClassTag and TypeTag classes.

As well as offering a richer mirror-based API, the new classes also seem to resolve a bug with reflection-based class loading in Manifest, which interacted badly with Play's DEV mode hot reloading.

Fixes #79

tsuckow commented 5 years ago

4.2.4, should be synced in a few hours

ashleymercer commented 5 years ago

Awesome - thanks :)