update guice dependency for scala > 2.11

codingwell / scala-guice

Scala extensions for Google Guice

Apache License 2.0

341 stars 44 forks source link

update guice dependency for scala > 2.11 #85

Closed samzilverberg closed 4 years ago

samzilverberg commented 4 years ago

added usage of guice 4.2.3 that supports java 14 for scala > 2.11

scala 2.11 is only supported up to java 11 according to this: https://docs.scala-lang.org/overviews/jdk-compatibility/overview.html

guice 4.2.3 release notes: https://github.com/google/guice/wiki/Guice423

tsuckow commented 4 years ago

Guice 4.2.3 still supports Java 8. So I updated to it across the board.

samzilverberg commented 4 years ago

your'e right, i thought i had some errors in tests for 2.11 but that was because initially i was trying the 4.2.3 version with "no_aop" classifier. ty for updating :)