search

codler / Battery-Time-Remaining

Show battery time remaining in Mac OS X 10.8+ Mountain Lion and Mavericks
http://yap.nu/battery-time-remaining/
Other
411 stars 72 forks source link

Compatibility with macOS Sierra (10.12 Beta) #105

Closed notDavid closed 8 years ago

notDavid commented 8 years ago

Hi,

It seems Battery Time Remaining 2 stopped working in macOS Sierra (10.12 Beta). I can see the app is running in Activity Monitor but i don't see anything happening in the Menu Bar.

I'm running the latest version downloaded from http://yap.nu/battery-time-remaining/download/Battery%20Time%20Remaining%202-3.0.zip

JustHyperX commented 8 years ago

Got this issue too the Battery Time Remaining v2 downloaded on App Store On opening the App content -> Content -> MacOS and run the exec to force activate it opens in terminal giving the reply

Cannot lock focus on image because it is size zero.

slvrscoobie commented 8 years ago

Same here - its 'running' but nothing shows in menu bar. Hope we can fix it :D

hanselsin commented 8 years ago

and it is still not working on the latest GM build 16A323 dated 15-Sept-2016. Please help!

EugeneFeingold commented 8 years ago

+1 doesn't work on 10.12 (16A323)

nbppp2 commented 8 years ago

I have taken a look at the code, and done a little debugging. It looks like the code points to the Apple icons. It looks like the location of those icons has moved for 10.12. The previous location was /System/Library/CoreServices/Menu Extras/Battery.menu/Contents/Resources/ see AppDelegate.m starting at line 619 to see the names of the files previously.

nbppp2 commented 8 years ago

It looks like these files have moved to /System/Library/PrivateFrameworks/BatteryUIKit.framework/Versions/A/Resources/ in macOS Sierra (10.12). I will make some changes to the code to support this and make a PR shortly. If anyone else is more versed in Objective-C and Mac development, feel free to beat me to the PR.

nbppp2 commented 8 years ago

107 Is my PR to fix this issue.

nbppp2 commented 8 years ago

I have published a build of the app here

EugeneFeingold commented 8 years ago

Works! Thanks!

slvrscoobie commented 8 years ago

ITS BACK! :D YAY!! THANK YOU!

es0phagus commented 8 years ago

Thanks so much

hanselsin commented 8 years ago

Thank you! It works like a charm!

alexbotev commented 8 years ago

No, it does not work. I had version 1.x, bought 2.x (now 3.1) because it was mentioned that it should work but it doesn't :( can you fix it please

purplespud commented 8 years ago

Thanks so very much nbppp2!

JustHyperX commented 8 years ago

Works! Thanks c",)

codler commented 8 years ago

An update are on its way

Turbo87 commented 7 years ago

@codler could you update http://yap.nu/battery-time-remaining/ with the new releases too?

codler commented 7 years ago

Having some trouble setting up my developer id on new computer..