search

codler / Battery-Time-Remaining

Show battery time remaining in Mac OS X 10.8+ Mountain Lion and Mavericks
http://yap.nu/battery-time-remaining/
Other
412 stars 72 forks source link

How do we are supposed to contribute to this project? #32

Closed MrAsterisco closed 12 years ago

MrAsterisco commented 12 years ago

This application is signed with a Developer ID. I do not own a Developer ID, so I cannot contribute to this project, since it does not compiles on my system.

I have disabled everything that is related to code signing, but making a pull request now would disable these options also in your project. How can I work on it?

codler commented 12 years ago

hm, good question. I don't know and Im not sure how others have done. Hopefully the others that have contributed can answer.

MrAsterisco commented 12 years ago

Anyway, I will make my edits and then offers you a pull request. I think you can just merge the project excluding certain files, or (the most simple) just merge and then change again your Project settings.

codler commented 12 years ago

You can exclude files when you commit, I would not like to change project settings back and forth.

MrAsterisco commented 12 years ago

Yeah, you're right. Sorry, I forgot that I could exclude files when committing. Thank you!

I have another question: I'm adding an option to hide the remaining time from the menu bar. What can I do for localizations? I can translate the application in Italian, but not in other languages...

codler commented 12 years ago

Hmm, why would you hide remaining time? The main purpose with this app is to show remaining time.

You can copy the english language file to Italian language folder and translate that file

MrAsterisco commented 12 years ago

Because I don't want to see it in the menu bar, but inside the application menu. My menu bar is already full of applications that take up to much space. I will include it inside the menu, when the "Show remaining time" option is disabled.

I know this, but for other languages? I'm going to add a new string that should be localized...

codler commented 12 years ago

The native battery app is showing remaining time inside the menu, so you can use that one instead in this case.

MrAsterisco commented 12 years ago

But the native battery app does not send notifications about the state of the battery...

codler commented 12 years ago

Alright, add a setting named "Show time remaning", but it will not come to next release "1.5.2", as 1.5.2 is ready to release, Im just w8ing for a localization.

MrAsterisco commented 12 years ago

Ok, that's fine. I will include in my commit the Italian localization: you can add it when you want.