Review code?

[codler]

This is my first mac app and I only have taken a beginner Iphone course before so I dont know so deep in objective c, so I wonder

• if someone with more expertise could check it has memory leaks ( or maybe teach how to check ) or do ARC take care of everything?
• if the code can be optimized much arbitrary?

[mac-cain13]

ARC should fix a lot of your memory issues for you, but hit the Product -> Analyze menuitem in XCode to make the compiler run a static analyzer that will check your code for a lot of mistakes and give hints about how to fix them. This is something you should do regularly to check for mistakes you overlooked.

Also check and read about Instruments, this is a great developer tool that helps inspect a lot of aspects of your App. You can look into performance, memory usage and energy usage with Instruments and you should get familiar with it. It really helps to understand what's going on in your App when you see strange behavior or want to optimize stuff.

If you need more info about Instruments check Apple's WWDC developer video's and the docs, they contain great tips, tricks and howto's! :)

Hope this helps! And of course if I notice anything that needs improvement I will send a pull request. :)

[codler]

Aha, thank you very much for the info! :) Ill run the Analyze then.^^ Instruments tool looks very complex :P

[osigge]

I'll take a look or two and provide some tests.

[osigge]

See https://github.com/codler/Battery-Time-Remaining/pull/41