search

codota / tabnine-vim

Vim client for TabNine. https://vimawesome.com/plugin/tabnine-vim
https://www.tabnine.com/install/vim
GNU General Public License v3.0
669 stars 36 forks source link

Incorrect binary directory name for 2.8.2 #63

Closed williamjameshandley closed 4 years ago

williamjameshandley commented 4 years ago

In release 2.8.2, the binaries are still stored in binaries/2.8.1

dimacodota commented 4 years ago

This release contains only plugin changes not binary(the binaries are still 2.8.1) Are you having problems with this release?

williamjameshandley commented 4 years ago

Only in that it messes up the aur build system, and if you're going to have a patch version number in the directory hierarchy, it should be consistent with the release number.

dimacodota commented 4 years ago

Hey @williamjameshandley, thanks for drawing our attention. can you please elaborate, how did this messed up? from what I see it pulls the whole extension from '$ {url} / archive / $ {pkgver} .tar.gz' which will pull the extension with its relevant binaries (as soon as pkgver is updated to 2.8.2)

dimacodota commented 4 years ago

@williamjameshandley - I found it, cp -r binaries/${pkgver}/x86_64-unknown-linux-musl/ $installpath/binaries/${pkgver} we are managing two separate release cycles for the plugin and for the binary. the binary version is determined by the .gitignore !binaries/version field

dimacodota commented 4 years ago

can your PKGBUILD be modified to pull the relevant binary version from .gitignore !binaries?

williamjameshandley commented 4 years ago

Ah, I see! one moment...

williamjameshandley commented 4 years ago

Great, that's pushed. Many thanks for your explanation and help @dimacodota

dimacodota commented 4 years ago

sure, no problem, BTW, i would suggest to always pull the latest plugin version by calling https://github.com/codota/tabnine-vim/releases/latest