codrops / DraggableDualViewSlideshow

A draggable slideshow with two views: fullscreen and small carousel. In fullscreen view, a related content area can be viewed.
224 stars 65 forks source link

adding slides causes breakdown #8

Open axelaos opened 10 years ago

axelaos commented 10 years ago

Hi, first off this is a really nice slider and I'm glad I found this. I added my own slides - 22 with respective content - and found that 12 slides seems to be the magic threshold for the whole thing to sort of crash - sliding will not work anymore, the switch icon will disapear, the current slide has no highlighted title and content cannot be accessed via keyboard anymore. Any idea why this happens and what I'd have to do to fix this? thanks, Axel

axelaos commented 10 years ago

Oh, and is there a way to lose the overlay with the icons that explain how the whole thing works? I tried to get rid of it in the css and the whole design fell to pieces: no slides, all text collapsing at the left side of the screen...

MickDK commented 10 years ago

I have the same issue as axelaos, I tried to get rid of landingpage at each 'update' of page: it loads evertytime - but really would like to get rid of it at all. Thanks - it's one hell of a job you've done there

axelaos commented 10 years ago

MickDK, my way around this little obstacle is rather clumsy in terms of neat and tidy coding but will work: just replace one line in the demo.css: .overlay { z-index: 10000; } with: .overlay { visibility: hidden; } This will not prevent the overlay from loading every time you call the page but at least it won't be visible. And yes, I know, this is far from elegant but I don'd dare medling with the .js. Unfortunately I have had no suggestions for my other problems. Somehow exceeding a certain number of slides will cause the arrow navigation to jam / freeze.

MickDK commented 10 years ago

@axelaos - that one i tried, it works. Regardless the code, which isn't as bad as it could be, thanks. Looking forward also, for a solution to work around the limit of 12 'frames'

LouisWhit commented 7 years ago

In the DragSlideshow.prototype._navigate function

Just check to see if this.current is greater than 12 but less than 13.

ex: this.current = this.dd.getStep()[0] - 1; if (this.current > 12 && this.current < 13) { this.current = 13; }

I have tested all the way to 24 slides. This appears to be the only rounding error I have hit so far.

cyrilmaillet commented 5 years ago

it cant work for me too, have try some codes, LouisWhit too, but it stop at the begining, i have more 250 pictures, manually slided ok, but not with the keyboard .