Closed JohnAllenTech closed 4 weeks ago
@JohnAllenTech is attempting to deploy a commit to the Codú Team on Vercel.
A member of the Team first needs to authorize it.
The changes in this pull request involve significant updates to the environment variable management for end-to-end (E2E) testing across multiple files. The README.md
file has been revised to reflect new variable names and the introduction of additional user session identifiers. The drizzle/seed.ts
file has been modified to accommodate the new structure for user data seeding. The E2E test suite has been adjusted to handle authenticated and unauthenticated user scenarios, and utility functions for user authentication have been added. Lastly, the sample.env
file has been updated to reflect the new variable names.
File | Change Summary |
---|---|
README.md |
Renamed E2E_USER_SESSION_ID to E2E_USER_ONE_SESSION_ID , added E2E_USER_TWO_SESSION_ID , removed E2E_USER_ID , added E2E_USER_ONE_ID and E2E_USER_TWO_ID . Updated descriptions for clarity. |
drizzle/seed.ts |
Added new user session and ID variables, updated seedE2EUser and seedE2EUserSession functions to accept parameters. Adjusted calls in addSeedDataToDb . |
e2e/articles.spec.ts |
Separated tests for authenticated and unauthenticated users, updated visibility checks and author name in tests. Enhanced scrolling behavior for loading articles. |
e2e/teardown.ts |
Expanded environment variable checks for cleanup, updated database deletion logic to handle new user IDs. |
e2e/utils/utils.ts |
Introduced loggedInAsUserOne and loggedInAsUserTwo functions for user authentication in E2E tests. |
sample.env |
Replaced E2E_USER_ID and E2E_USER_SESSION_ID with new variables for two users. |
README.md
regarding environment variables for E2E testing.README.md
regarding database setup commands that may impact environment variable configurations.hacktoberfest-accepted
, hacktoberfest
Hop, hop, hooray, what a change today!
User sessions now in twos, oh what fun to play!
With IDs and tokens, our tests shall soar,
E2E adventures, we shall explore!
Bouncing through code, with joy we’ll sing,
For every new variable, let the rabbit dance and spring! 🐇✨
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
codu | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Oct 28, 2024 8:21pm |
This ones good to go @NiallJoeMaher
Uh oh! @JohnAllenTech, the image you shared is missing helpful alt text. Check https://github.com/codu-code/codu/pull/1182#issuecomment-2442597176.
Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image.
Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.
✨ Codu Pull Request 💻
Will need to be merged after #1181
Pull Request details
Follow on from #1181. Now creating two E2E users and supporting using them in our E2E test suite.
This unlocks the ability to test interaction between two users in an E2E Test. ie one user comments on another users comment
Any Breaking changes
You can do this by running
Associated Screenshots
All tests passing locally