search

codu-code / codu

Codú's open-source codebase. A space for coders. Visit our community!
https://codu.co/
Apache License 2.0
141 stars 145 forks source link

feat(alpha-editor): update tooltip layout and organize modifiers #1196

Closed dineshsutihar closed 3 weeks ago

dineshsutihar commented 3 weeks ago

✨ Codu Pull Request 💻

Fixes #1195

Pull Request details

Any Breaking changes

None

Associated Screenshots

Tooltip With Active State Tooltip With Dropdown

[Optional] What gif best describes this PR or how it makes you feel

None

vercel[bot] commented 3 weeks ago

@dineshsutihar is attempting to deploy a commit to the Codú Team on Vercel.

A member of the Team first needs to authorize it.

coderabbitai[bot] commented 3 weeks ago

Walkthrough

The changes in this pull request involve modifications to three components: EditorBubbleMenu, LinkSelector, and NodeSelector. The EditorBubbleMenu has had the "code" option removed and improved error handling for editor commands. The LinkSelector now uses a single Link icon instead of multiple icons and has disabled URL input functionality. The NodeSelector has streamlined its options by removing several items and refining the active state logic. These updates enhance the overall functionality and user experience of the editor components.

Changes

File Path Change Summary
components/editor/editor/components/bubble-menu.tsx Removed "code" option, improved error handling with optional chaining and nullish coalescing, updated rendering logic for selectors.
components/editor/editor/components/link-selector.tsx Replaced multiple icons with a single Link icon, commented out URL input form, retained core link management functionality.
components/editor/editor/components/node-selector.tsx Removed "Code", "Bullet List", and "Numbered List" options, simplified "Text" active check, adjusted "Quote" command, added aria-expanded for accessibility.

Assessment against linked issues

Objective Addressed Explanation
Modify tooltip on alpha editor (Issue #1195) ❌ The changes do not address tooltip modifications as specified.

Possibly related PRs

Suggested labels

hacktoberfest-accepted, hacktoberfest

Poem

🐇 In the editor's realm, changes take flight,
With icons simplified, everything feels right.
No more "code" to clutter the view,
Just bold and italic, for the writer in you.
So hop along, let creativity flow,
In this bubble of joy, let your ideas grow! 🌟

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
John-Paul-Larkin commented 3 weeks ago

Hi @dineshsutihar This looks good. Thanks. However, the link feature is giving me an error. Can you confirm you get this error? We can make a separate issue to fix this.

https://github.com/user-attachments/assets/51735afc-b17b-4d53-94ad-546e8894c052

dineshsutihar commented 3 weeks ago

Hi @dineshsutihar This looks good. Thanks. However, the link feature is giving me an error. Can you confirm you get this error? We can make a separate issue to fix this.

Screen.Recording.2024-10-30.at.16.16.16.mov

Yes, there’s a pre-existing issue with the link feature, and I was planning to create a new issue to address it separately. Additionally, I think a new UI for the link feature would be beneficial. Whenever we click on the link button, it could open a pop-up like this and prompt for a link. What do you think of this design? @John-Paul-Larkin

sample image for link

Could you please create a new issue and assign it to me? I’ll submit a separate PR to fix it.