coduin / epiphany-bsp

BSP implementation for the Parallella; the world's smallest supercomputer
https://jwbuurlage.github.io/epiphany-bsp/
GNU General Public License v3.0
27 stars 14 forks source link

Correction of remaining bytes in memcopy aligned cases #33

Closed kmate closed 8 years ago

kmate commented 8 years ago

There is a typo-like error in the aligned cases of ebsp_memcpy. The remaining bytes will not be copied correctly, as the source pointer is not changed. I attached a standalone test case that shows the output of each version.

jwbuurlage commented 8 years ago

Hi Karácsony, thanks for this fix. Do you mind if I add you as a contributor under the Authors section of our README?

kmate commented 8 years ago

Yes, you could add me, thanks. In the meanwhile I corrected how my name is displayed on my account, so my "first name" (given name) is Máté, but in hungary we use it in the other way... (Hence hungarian notation in programming)

jwbuurlage commented 8 years ago

Hi again Máté, thanks for letting me know, and forgive my ignorance of Hungarian naming conventions :)

kmate commented 8 years ago

No problem, usually nobody knows it, this is why I also changed my account :)