search

codyhouse / codyhouse-framework

A lightweight front-end framework for building accessible, bespoke interfaces.
https://codyhouse.co/
MIT License
1.16k stars 173 forks source link

Mobile navigation needs trapping #35

Closed djmtype closed 5 years ago

djmtype commented 5 years ago

When it comes to keyboard access, the mobile menu of the main header should probably include trapping (like the Dialog component). Meaning, when it's toggled open, tabbing through will recycle back to the MENU button instead of tabbing to the main content which lays underneath, and no longer accessible.

https://codyhouse.co/ds/components/app/main-header

sebastiano-guerriero commented 5 years ago

Hi there! I'm not 100% sure trapping would be the best approach in this case. You can go back to the navigation by clicking shift+tab (or swift left on a phone). However, it is true blind users don't know they're "leaving" the navigation. Plus the next focusable item could be under the navigation popup, causing issues to users navigating the content with their keyboard. We'll collect more data and get back to this. Thanks for the feedback!

I'm closing this issue because it's not strictly related to the framework, but to a component.