Forcing integrated card not working

codykrieger / gfxCardStatus

gfxCardStatus is an open-source menu bar application that keeps track of which graphics card your unibody, dual-GPU MacBook Pro is using at any given time, and allows you to switch between them on demand.

https://gfx.io

Other

1.68k stars 321 forks source link

Forcing integrated card not working #368

Closed carlosbaraza closed 3 years ago

carlosbaraza commented 3 years ago

I'm not sure why, but it is not possible to change to integrated graphics on my MacBook Pro (15-inch, 2019).

Kapture 2021-06-08 at 17 44 43

Anyone has a workaround?

bpress commented 3 years ago

The very same issue is happening on my MacBook Pro 16 2019. Switching from dynamic to integrated activates the Radeon card. There's no way to activate the Intel card even with the mac idling (no apps with visible windows running other than the Finder).

renesansz commented 3 years ago

same issue here. I'm on Macbook Pro 15" (Mid-2015) - Dual GPU, MacOS Big Sur 11.4.

RoadToDream commented 3 years ago

same issue here. I'm on Macbook Pro 15" (Mid-2015) - Dual GPU, MacOS Big Sur 11.4.

@renesansz @bpress @carlosbaraza please consider this build

gfxCardStatus.app.zip

renesansz commented 3 years ago

@RoadToDream it seems it's broken

RoadToDream commented 3 years ago

@RoadToDream it seems it's broken

@renesansz Hahaha that's embarrassing.. My bad

Let me sign this package and re-upload.

RoadToDream commented 3 years ago

@renesansz I have updated the file and you may give it a try. Wish this build works for you(I may upload a validated build several days later once Apple fixed my developer account, but till now you may need to approve it in settings app).

gfxCardStatus.app.zip

codykrieger commented 3 years ago

@RoadToDream What changes have you made in this build?

codykrieger commented 3 years ago

This is likely a duplicate of #331, so we'll track this there.

RoadToDream commented 3 years ago

@RoadToDream What changes have you made in this build?

Hi codykrieger! Thank you for bringing this useful app, this is the best among all similar tools(especially it can preserve hardware info even after applying the callback)

Original implementation is perfect and it does perform the forcing switch, but the UI does not perform correspondingly. isOnIntegratedOnlyMode in GSMux will always return a false as newer Macs will return NO to (self.isUsingOldStyleSwitchPolicy || [GSGPU is2010MacBookPro]). This will affect the setstate operation in GSMenuController.

RoadToDream commented 3 years ago

This is likely a duplicate of #331, so we'll track this there.

Of course that might not be the cause for some other similar issues, but I would just like to report that this causes the undesirable behavior on my 2017 15'' and 2019 16'' Mac.

codykrieger commented 3 years ago

@RoadToDream Oh, wow, that's a really silly bug. Thanks for finding that! I unfortunately no longer have a dual-GPU machine to test with, but if you'd like to send a pull request, I'd be happy to accept it.

RoadToDream commented 3 years ago

@RoadToDream Oh, wow, that's a really silly bug. Thanks for finding that! I unfortunately no longer have a dual-GPU machine to test with, but if you'd like to send a pull request, I'd be happy to accept it.

Of course! Would be honored Pull request submitted.
isOnIntegratedOnlyMode in GSMux remains the same as I don't want to hurt users of old Mac. Only MenuController is modified, which should be enough

bpress commented 3 years ago

@RoadToDream I've just tested it on my MacBook Pro 16 2019 - Big Sur but still no success:

If I leave it on automatic, it show the "i" icon; if I try to force a manual switch to integrated or discrete, it always switches to the Radeon card.

RoadToDream commented 3 years ago

@RoadToDream I've just tested it on my MacBook Pro 16 2019 - Big Sur but still no success:

If I leave it on automatic, it show the "i" icon; if I try to force a manual switch to integradet or discrete, it always switches to the Radeon card.

That's really sad. I am sorry that I can not reproduce this error on my 2019 16.

Would you like to check Activity monitor-energy, is it showing Integrated card or Discrete Card after you force a manual switch to integrated?

bpress commented 3 years ago

That's really sad. I am sorry that I can not reproduce this error on my 2019 16.

Would you like to check Activity monitor-energy, is it showing Integrated card or Discrete Card after you force a manual switch to integrated?

@RoadToDream sure, here are the 3 cases

Automatic:

Discrete:

Integrated (still using discrete):

RoadToDream commented 3 years ago

@bpress Thank you! That's a weird error and I have to say I have no idea why it happened.

I will try to debug, but that error may related to something more complicated.

bpress commented 3 years ago

@RoadToDream

I will try to debug, but that error may related to something more complicated.

Ok, let me know if I can be of any help.