fix(package): add `webpack >= v4.0.0` (`peerDependencies`)

codymikol / karma-webpack

Karma webpack Middleware

MIT License

830 stars 222 forks source link

fix(package): add `webpack >= v4.0.0` (`peerDependencies`) #301

Closed pine closed 6 years ago

pine commented 6 years ago

Hello. I've updated peerDependencies. Thank you.

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Other: Update dependencies

Does this PR introduce a breaking change?

[ ] Yes
[x] No

jsf-clabot commented 6 years ago

All committers have signed the CLA.

mikegreiling commented 6 years ago

Although this marks karma-webpack as supporting webpack v4.0.0, yarn will still throw warnings when installing because the webpack-dev-middleware v1.12.0 dependency does not have webpack 4 as a valid peerDependency.

Could we update webpack-dev-middleware to v2 as well? Are there many breaking changes?

michael-ciniawsky commented 6 years ago

I'm cutting a release with some chore attached right now, but this is the only dependency I'm not sure if it can be upgraded or the peerDependency could be raised for webpack-dev-middleware >= 1.12.0 instead etc etc...

michael-ciniawsky commented 6 years ago

Nope https://github.com/webpack/webpack-dev-middleware/blob/master/breaking-changes.md 😞

michael-ciniawsky commented 6 years ago

Released in v2.0.10 🎉