codymikol / karma-webpack

Karma webpack Middleware
MIT License
830 stars 222 forks source link

chore(package): update `webpack-dev-middleware` v1.12.0...2.0.6 (`dependencies`) #318

Closed limonte closed 6 years ago

limonte commented 6 years ago

Fixes #314

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Does this PR introduce a breaking change?

If this PR contains a breaking change, please describe the following...

Other information:

jsf-clabot commented 6 years ago

CLA assistant check
All committers have signed the CLA.

michael-ciniawsky commented 6 years ago

What's the exact issue you're facing and would #315 fix it? Note that #315 requires webpack >= v4.0.0 && node >= v6.0.0. If that's sufficient I would favor #315 over this PR instead

limonte commented 6 years ago

What's the exact issue you're facing and would #315 fix it?

Oh, I didn't notice #315, apologies. Basically, it's the same, but as you said

315 requires webpack >= v4.0.0

and this PR will still support webpack 2 and 3.

315 will work for me personally (we're trying to fix flaky https://github.com/sweetalert2/sweetalert2/issues/986) so I'm okay to close this PR in favor of #315

michael-ciniawsky commented 6 years ago

It should eventually be possible to support webpack =< v4.0.0 in #315 aswell, depending on webpack-dev-middleware v2.0.0 <=> v3.0.0 (But I think v3.0.0 is webpack >= v4.0.0 aswell 😭) so maybe we need to majors version bumps then 😒

limonte commented 6 years ago

so maybe we need to majors version bumps then

I don't see anything wrong with two major bumps in this case. With proper release titles and release notes, developers will appreciate two different majors for webpack ^2.0.0 - ^4.0.0 projects and webpack ^4.0.0 projects.

michael-ciniawsky commented 6 years ago

Released in v3.0.0 🎉 Thx